pgsql: Avoid using ambiguous word "non-negative" in error messages.

From: Fujii Masao <fujii(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Avoid using ambiguous word "non-negative" in error messages.
Date: 2021-07-27 16:29:56
Message-ID: E1m8Pxs-0004RB-Hl@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Avoid using ambiguous word "non-negative" in error messages.

The error messages using the word "non-negative" are confusing
because it's ambiguous about whether it accepts zero or not.
This commit improves those error messages by replacing it with
less ambiguous word like "greater than zero" or
"greater than or equal to zero".

Also this commit added the note about the word "non-negative" to
the error message style guide, to help writing the new error messages.

When postgres_fdw option fetch_size was set to zero, previously
the error message "fetch_size requires a non-negative integer value"
was reported. This error message was outright buggy. Therefore
back-patch to all supported versions where such buggy error message
could be thrown.

Reported-by: Hou Zhijie
Author: Bharath Rupireddy
Reviewed-by: Kyotaro Horiguchi, Fujii Masao
Discussion: https://postgr.es/m/OS0PR01MB5716415335A06B489F1B3A8194569@OS0PR01MB5716.jpnprd01.prod.outlook.com

Branch
------
REL_12_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/de87c481f635953e84e7d3b404e15700301bcdac

Modified Files
--------------
contrib/postgres_fdw/option.c | 13 ++++++++-----
doc/src/sgml/sources.sgml | 10 ++++++++++
src/backend/partitioning/partbounds.c | 4 ++--
src/backend/utils/adt/tsquery_op.c | 2 +-
src/test/modules/test_shm_mq/test.c | 10 +++++-----
src/test/regress/expected/hash_part.out | 4 ++--
6 files changed, 28 insertions(+), 15 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Fujii Masao 2021-07-27 16:30:09 pgsql: Avoid using ambiguous word "non-negative" in error messages.
Previous Message Fujii Masao 2021-07-27 16:29:43 pgsql: Avoid using ambiguous word "non-negative" in error messages.