| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Remove configure-time thread safety checking (thread_test.c). |
| Date: | 2021-07-24 16:16:59 |
| Message-ID: | E1m7KKh-00038A-Pw@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Remove configure-time thread safety checking (thread_test.c).
This testing was useful when it was written, nigh twenty years ago,
but it seems fairly pointless for any platform built in the last
dozen or more years. (Compare also the comments at 8a2121185.)
Also we now have reports that the test program itself fails under
ThreadSanitizer. Rather than invest effort in fixing it, let's
just drop it, and assume that the few people who still care
already know they need to use --disable-thread-safety.
Back-patch into v14, for consistency with 8a2121185.
Discussion: https://postgr.es/m/CADhDkKzPSiNvA3Hyq+wSR_icuPmazG0cFe=YnC3U-CFcYLc8Xw@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/76fa3db33654e543b5c796e28c6fc5b505a19c2a
Modified Files
--------------
config/thread_test.c | 433 ---------------------------------------------------
configure | 194 +++++------------------
configure.ac | 38 +----
3 files changed, 43 insertions(+), 622 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2021-07-24 17:41:47 | pgsql: Make printf("%s", NULL) print "(null)" instead of crashing. |
| Previous Message | Tom Lane | 2021-07-24 15:35:05 | pgsql: Fix failure of some headers to compile "standalone". |