| From: | Thomas Munro <tmunro(at)postgresql(dot)org> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: jit: Don't inline functions that access thread-locals. |
| Date: | 2021-07-22 03:24:36 |
| Message-ID: | E1m6PK8-00088f-3p@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
jit: Don't inline functions that access thread-locals.
Code inlined by LLVM can crash or fail with "Relocation type not
implemented yet!" if it tries to access thread local variables. Don't
inline such code.
Back-patch to 11, where LLVM arrived. Bug #16696.
Author: Dmitry Marakasov <amdmi3(at)amdmi3(dot)ru>
Reviewed-by: Andres Freund <andres(at)anarazel(dot)de>
Discussion: https://postgr.es/m/16696-29d944a33801fbfe@postgresql.org
Branch
------
REL_14_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/b1c1b7af573bbc9fe9039c82ffb7d3a3c378fe4a
Modified Files
--------------
src/backend/jit/llvm/llvmjit_inline.cpp | 11 +++++++++++
1 file changed, 11 insertions(+)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2021-07-22 03:24:50 | pgsql: jit: Don't inline functions that access thread-locals. |
| Previous Message | Thomas Munro | 2021-07-22 03:24:22 | pgsql: jit: Don't inline functions that access thread-locals. |