pgsql: Make XLOG_FPI_FOR_HINT records honor full_page_writes setting.

From: Fujii Masao <fujii(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Make XLOG_FPI_FOR_HINT records honor full_page_writes setting.
Date: 2021-07-21 02:19:49
Message-ID: E1m61pt-0006RR-8U@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Make XLOG_FPI_FOR_HINT records honor full_page_writes setting.

Commit 2c03216d83 changed XLOG_FPI_FOR_HINT records so that they always
included full-page images even when full_page_writes was disabled. However,
in this setting, they don't need to do that because hint bit updates don't
need to be protected from torn writes.

Therefore, this commit makes XLOG_FPI_FOR_HINT records honor full_page_writes
setting. That is, XLOG_FPI_FOR_HINT records may include no full-page images
if full_page_writes is disabled, and WAL replay of them does nothing.

Reported-by: Zhang Wenjie
Author: Kyotaro Horiguchi
Reviewed-by: Fujii Masao
Discussion: https://postgr.es/m/tencent_60F11973A111EED97A8596FFECC4A91ED405@qq.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/7fcf2faf9c7dd473208fd6d5565f88d7f733782b

Modified Files
--------------
src/backend/access/transam/xlog.c | 32 +++++++++++++++++++++-----------
src/backend/access/transam/xloginsert.c | 5 +----
2 files changed, 22 insertions(+), 15 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Fujii Masao 2021-07-21 04:56:26 pgsql: doc: Document that only superusers can use pg_import_system_coll
Previous Message Michael Paquier 2021-07-20 23:43:55 Re: pgsql: Re-enable TAP tests of pg_receivewal for ZLIB on Windows