| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Make new replication slot test code less racy |
| Date: | 2021-07-17 17:35:39 |
| Message-ID: | E1m4oDz-00009d-Pg@gemulon.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Make new replication slot test code less racy
The new test code added in ead9e51e8236 is racy -- it hinges on
shared-memory state, which changes before the WARNING message is logged.
Put it the other way around.
Backpatch to 13.
Author: Álvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Discussion: https://postgr.es/m/202107161809.zclasccpfcg3@alvherre.pgsql
Branch
------
REL_13_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/7099ba0580356bb455d75de4f6cd0faa046e1a10
Modified Files
--------------
src/test/recovery/t/019_replslot_limit.pl | 27 +++++++++++++++------------
1 file changed, 15 insertions(+), 12 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dean Rasheed | 2021-07-18 10:11:11 | pgsql: Improve error checking of CREATE COLLATION options. |
| Previous Message | Tom Lane | 2021-07-17 15:53:24 | pgsql: Doc: document the current-transaction-modes GUCs. |