pgsql: Robustify tuplesort's free_sort_tuple function

From: David Rowley <drowley(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Robustify tuplesort's free_sort_tuple function
Date: 2021-07-13 01:28:04
Message-ID: E1m37DQ-0006te-RZ@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Robustify tuplesort's free_sort_tuple function

41469253e went to the trouble of removing a theoretical bug from
free_sort_tuple by checking if the tuple was NULL before freeing it. Let's
make this a little more robust by also setting the tuple to NULL so that
should we be called again we won't end up doing a pfree on the already
pfree'd tuple. Per advice from Tom Lane.

Discussion: https://postgr.es/m/3188192.1626136953@sss.pgh.pa.us
Backpatch-through: 9.6, same as 41469253e

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/a92709fed63428a711f36270a2b4bee039399d60

Modified Files
--------------
src/backend/utils/sort/tuplesort.c | 1 +
1 file changed, 1 insertion(+)

Browse pgsql-committers by date

  From Date Subject
Next Message David Rowley 2021-07-13 01:28:40 pgsql: Robustify tuplesort's free_sort_tuple function
Previous Message David Rowley 2021-07-13 01:27:28 pgsql: Robustify tuplesort's free_sort_tuple function