From: | Michael Paquier <michael(at)paquier(dot)xyz> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Revert "Fix issues with Windows' stat() for files pending on del |
Date: | 2021-07-12 05:47:02 |
Message-ID: | E1m2omU-00062G-O9@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Revert "Fix issues with Windows' stat() for files pending on deletion"
This reverts commit 54fb8c7, as per the issues reported by fairywren
when it comes to MinGW because of the lack of microsoft_native_stat()
there. Using just stat() for MSVC is not sufficient to take care of the
concurrency problems with files pending on deletion. It may be possible
to paint some __MINGW64__ in the code to switch to a different
implementation of stat() in this build context, but I am not sure either
if relying on the implementation of stat() in MinGW to take care of the
problems we are trying to fix is enough or not. So this needs more
study.
Discussion: https://postgr.es/m/YOvOlfRrIO0yGtgw@paquier.xyz
Backpatch-through: 14
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/2c9b46c090e76c62f24563b9be2c34e6b92e9329
Modified Files
--------------
src/port/open.c | 4 +-
src/port/win32stat.c | 177 +++++++++++++++++++++++++++++++++++++--------------
2 files changed, 132 insertions(+), 49 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Eisentraut | 2021-07-12 06:57:52 | pgsql: doc: Make release note entries more accurate |
Previous Message | Michael Paquier | 2021-07-12 04:03:09 | pgsql: Fix issues with Windows' stat() for files pending on deletion |