From: | Michael Paquier <michael(at)paquier(dot)xyz> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: pageinspect: Improve page_header() for pages of 32kB |
Date: | 2021-07-12 02:13:58 |
Message-ID: | E1m2lSI-0004l0-UV@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
pageinspect: Improve page_header() for pages of 32kB
ld_upper, ld_lower, pd_special and the page size have been using
smallint as return type, which could cause those fields to return
negative values in certain cases for builds configures with a page size
of 32kB.
Bump pageinspect to 1.10. page_header() is able to handle the correct
return type of those fields at runtime when using an older version of
the extension, with some tests are added to cover that.
Author: Quan Zongliang
Reviewed-by: Michael Paquier, Bharath Rupireddy
Discussion: https://postgr.es/m/8b8ec36e-61fe-14f9-005d-07bc85aa4eed@yeah.net
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/127404fbe28455d6e8183fa58f3b7aefeba8f909
Modified Files
--------------
contrib/pageinspect/Makefile | 2 +-
contrib/pageinspect/expected/oldextversions.out | 16 +++++++++++++
contrib/pageinspect/pageinspect--1.9--1.10.sql | 21 +++++++++++++++++
contrib/pageinspect/pageinspect.control | 2 +-
contrib/pageinspect/rawpage.c | 31 +++++++++++++++++++++----
contrib/pageinspect/sql/oldextversions.sql | 6 +++++
6 files changed, 72 insertions(+), 6 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2021-07-12 04:03:09 | pgsql: Fix issues with Windows' stat() for files pending on deletion |
Previous Message | Tom Lane | 2021-07-11 16:54:58 | pgsql: Lock the extension during ALTER EXTENSION ADD/DROP. |