pgsql: Improve TestLib::system_or_bail error reporting

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Improve TestLib::system_or_bail error reporting
Date: 2021-07-06 21:53:51
Message-ID: E1m0t0p-00009m-KA@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Improve TestLib::system_or_bail error reporting

The original coding was not quoting the complete failing command, and it
wasn't printing the reason for the failure either. Do both.

This is cosmetic only, so no backpatch.

Author: Álvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Reviewed-by: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Reviewed-by: Daniel Gustafsson <daniel(at)yesql(dot)se>
Discussion: https://postgr.es/m/202106301524.eq5pblzstapj@alvherre.pgsql

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/5798ca529935698ab976780565fb2b4d8d34d810

Modified Files
--------------
src/test/perl/TestLib.pm | 24 ++++++++++++++++++++++--
1 file changed, 22 insertions(+), 2 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2021-07-06 22:10:28 pgsql: Allow CustomScan providers to say whether they support projectio
Previous Message Tom Lane 2021-07-06 18:23:16 pgsql: Reduce the cost of planning deeply-nested views.