pgsql: Refactor function parse_subscription_options.

From: Amit Kapila <akapila(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Refactor function parse_subscription_options.
Date: 2021-07-06 02:44:49
Message-ID: E1m0b4r-00011P-Rp@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Refactor function parse_subscription_options.

Instead of using multiple parameters in parse_subscription_options
function signature, use the struct SubOpts that encapsulate all the
subscription options and their values. It will be useful for future work
where we need to add other options in the subscription. Also, use bitmaps
to pass the supported and retrieve the specified options much like the way
it is done in the commit a3dc926009.

Author: Bharath Rupireddy
Reviewed-By: Peter Smith, Amit Kapila, Alvaro Herrera
Discussion: https://postgr.es/m/CALj2ACXtoQczfNsDQWobypVvHbX2DtgEHn8DawS0eGFwuo72kw@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/8aafb02616753f5c6c90bbc567636b73c0cbb9d4

Modified Files
--------------
src/backend/commands/subscriptioncmds.c | 439 +++++++++++++++-----------------
src/tools/pgindent/typedefs.list | 1 +
2 files changed, 207 insertions(+), 233 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2021-07-06 14:35:18 pgsql: Doc: add info about timestamps with fractional-minute UTC offset
Previous Message David Rowley 2021-07-06 00:39:27 pgsql: Fix typo in comment