| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Remove dry-run mode from isolationtester |
| Date: | 2021-06-17 02:03:00 |
| Message-ID: | E1lthMy-0004oY-3I@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Remove dry-run mode from isolationtester
The original purpose of the dry-run mode is to be able to print all the
possible permutations from a spec file, but it has become less useful
since isolation tests have improved regarding deadlock detection as one
step not wanted by the author could block indefinitely now (originally
the step blocked would have been detected rather quickly). Per
discussion, let's remove it.
This is a backpatch of 9903338 for 9.6~12. It is proving to become
useful to have on those branches so as the code gets consistent across
all supported versions, as a matter of improving the output generated by
isolationtester.
Author: Michael Paquier
Reviewed-by: Asim Praveen, Melanie Plageman
Discussion: https://postgr.es/m/20190819080820.GG18166@paquier.xyz
Discussion: https://postgr.es/m/794820.1623872009@sss.pgh.pa.us
Backpatch-through: 9.6
Branch
------
REL_10_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/0ed218048932bf55e0d19c9a6e06bd40900e7b1b
Modified Files
--------------
src/test/isolation/isolationtester.c | 31 +------------------------------
1 file changed, 1 insertion(+), 30 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2021-06-17 02:58:38 | pgsql: Detect unused steps in isolation specs and do some cleanup |
| Previous Message | Tom Lane | 2021-06-16 23:30:34 | pgsql: Fix plancache refcount leak after error in ExecuteQuery. |