pgsql: Fix logic bug in 1632ea43682f

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix logic bug in 1632ea43682f
Date: 2021-06-14 20:32:45
Message-ID: E1lstGH-0003NL-UZ@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix logic bug in 1632ea43682f

I overlooked that one condition was logically inverted. The fix is a
little bit more involved than simply negating the condition, to make
the code easier to read.

Fix some outdated comments left by the same commit, while at it.

Author: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
Author: Álvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Reviewed-by: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Discussion: https://postgr.es/m/YMRlmB3/lZw8YBH+(at)paquier(dot)xyz

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/33c509956704e1d918077b51ccd954f2e201a8f5

Modified Files
--------------
src/backend/replication/slot.c | 30 ++++++++++++++++--------------
1 file changed, 16 insertions(+), 14 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Noah Misch 2021-06-15 00:30:00 pgsql: Remove pg_wait_for_backend_termination().
Previous Message Bruce Momjian 2021-06-14 20:14:14 pgsql: doc: PG 14 relnotes fixes