pgsql: Fix multiple crasher bugs in partitioned-table replication logic

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix multiple crasher bugs in partitioned-table replication logic
Date: 2021-06-11 20:12:57
Message-ID: E1lrnWT-0007hr-61@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix multiple crasher bugs in partitioned-table replication logic.

apply_handle_tuple_routing(), having detected and reported that
the tuple it needed to update didn't exist, tried to update that
tuple anyway, leading to a null-pointer dereference.

logicalrep_partition_open() failed to ensure that the
LogicalRepPartMapEntry it built for a partition was fully
independent of that for the partition root, leading to
trouble if the root entry was later freed or rebuilt.

Meanwhile, on the publisher's side, pgoutput_change() sometimes
attempted to apply execute_attr_map_tuple() to a NULL tuple.

The first of these was reported by Sergey Bernikov in bug #17055;
I found the other two while developing some test cases for this
sadly under-tested code.

Diagnosis and patch for the first issue by Amit Langote; patches
for the others by me; new test cases by me. Back-patch to v13
where this logic came in.

Discussion: https://postgr.es/m/17055-9ba800ec8522668b@postgresql.org

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/b270713fd44b1378cebc3177e092add0155b55b6

Modified Files
--------------
src/backend/replication/logical/relation.c | 13 ++++--
src/backend/replication/logical/worker.c | 49 +++++++++++---------
src/backend/replication/pgoutput/pgoutput.c | 7 ++-
src/test/subscription/t/001_rep_changes.pl | 36 ++++++++++++++-
src/test/subscription/t/013_partition.pl | 71 ++++++++++++++++++++++++++++-
5 files changed, 147 insertions(+), 29 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2021-06-11 23:08:29 pgsql: Report sort phase progress in parallel btree build
Previous Message Alvaro Herrera 2021-06-11 20:07:38 pgsql: Add 'Portal Close' message to pipelined PQsendQuery()