pgsql: Standardize usages of appendStringInfo and appendPQExpBuffer

From: David Rowley <drowley(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Standardize usages of appendStringInfo and appendPQExpBuffer
Date: 2021-06-03 04:38:26
Message-ID: E1lof7i-0004bO-1i@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Standardize usages of appendStringInfo and appendPQExpBuffer

Fix a few places that were using appendStringInfo() when they should have
been using appendStringInfoString(). Also some cases of
appendPQExpBuffer() that would have been better suited to use
appendPQExpBufferChar(), and finally, some places that used
appendPQExpBuffer() when appendPQExpBufferStr() would have suited better.

There are no bugs are being fixed here. The aim is just to make the code
use the most optimal function for the job.

All the code being changed here is new to PG14. It makes sense to fix
these before we branch for PG15. There are a few other places that we
could fix, but those cases are older code so fixing those seems less
worthwhile as it may cause unnecessary back-patching pain in the future.

Author: Hou Zhijie
Discussion: https://postgr.es/m/OS0PR01MB5716732158B1C4142C6FE375943D9@OS0PR01MB5716.jpnprd01.prod.outlook.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/f736e188ce70bda34f04c9f381b7c5141dc20dce

Modified Files
--------------
src/backend/access/brin/brin_minmax_multi.c | 2 +-
src/backend/access/heap/vacuumlazy.c | 8 ++++----
src/bin/pg_amcheck/pg_amcheck.c | 2 +-
src/bin/psql/describe.c | 6 +++---
4 files changed, 9 insertions(+), 9 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2021-06-03 05:05:37 pgsql: doc: Group options in pg_amcheck reference page
Previous Message Michael Paquier 2021-06-03 02:52:43 pgsql: Ignore more environment variables in TAP tests