From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Sync guc.c and postgresql.conf.sample with the SGML docs. |
Date: | 2021-05-08 16:13:39 |
Message-ID: | E1lfPaF-00048s-Sq@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Sync guc.c and postgresql.conf.sample with the SGML docs.
It seems that various people have moved GUCs around in the config.sgml
listing without bothering to make the code agree. Ensure that the
config_group codes assigned to GUCs match where they are listed in
config.sgml. Likewise ensure that postgresql.conf.sample lists GUCs
in the same sub-section and same ordering as they appear in config.sgml.
(I've got some doubts about some of these choices, but for the purposes
of this patch, we'll treat config.sgml as gospel.)
Notably, this requires adding a WAL_RECOVERY config_group value,
because 1d257577e didn't. As long as we're renumbering that enum
anyway, let's take out the values corresponding to major groups
that are divided into sub-groups. No GUC should be assigned to the
major group itself, so those values just create a temptation to
do the wrong thing, while adding work for translators.
In passing, adjust the short_desc strings for PRESET_OPTIONS GUCs
to uniformly use the phrasing "Shows XYZ.", removing the impression
some of these strings left that you can set the value.
While some of these errors are old, no back-patch, as changing the
contents of the pg_settings view in stable branches seems more likely
to be seen as a compatibility break than anything helpful.
Bharath Rupireddy, Justin Pryzby, Tom Lane
Discussion: https://postgr.es/m/16997-ff16127f6e0d1390@postgresql.org
Discussion: https://postgr.es/m/20210413123139.GE6091@telsasoft.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/a55a98477b690dedb9b4368d7e5710c8e7fa534e
Modified Files
--------------
src/backend/utils/misc/guc.c | 56 ++++++----------
src/backend/utils/misc/postgresql.conf.sample | 95 +++++++++++++--------------
src/include/utils/guc_tables.h | 15 ++---
3 files changed, 71 insertions(+), 95 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | David Rowley | 2021-05-08 23:37:41 | pgsql: Move memory accounting Asserts for Result Cache code |
Previous Message | Tom Lane | 2021-05-08 15:33:25 | pgsql: Doc: copy-editing for debug_invalidate_system_caches_always desc |