pgsql: Revert per-index collation version tracking feature.

From: Thomas Munro <tmunro(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Revert per-index collation version tracking feature.
Date: 2021-05-07 09:59:15
Message-ID: E1lexGN-0001Fd-Fb@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Revert per-index collation version tracking feature.

Design problems were discovered in the handling of composite types and
record types that would cause some relevant versions not to be recorded.
Misgivings were also expressed about the use of the pg_depend catalog
for this purpose. We're out of time for this release so we'll revert
and try again.

Commits reverted:

1bf946bd: Doc: Document known problem with Windows collation versions.
cf002008: Remove no-longer-relevant test case.
ef387bed: Fix bogus collation-version-recording logic.
0fb0a050: Hide internal error for pg_collation_actual_version(<bad OID>).
ff942057: Suppress "warning: variable 'collcollate' set but not used".
d50e3b1f: Fix assertion in collation version lookup.
f24b1569: Rethink extraction of collation dependencies.
257836a7: Track collation versions for indexes.
cd6f479e: Add pg_depend.refobjversion.
7d1297df: Remove pg_collation.collversion.

Discussion: https://postgr.es/m/CA%2BhUKGLhj5t1fcjqAu8iD9B3ixJtsTNqyCCD4V0aTO9kAKAjjA%40mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/ec48314708262d8ea6cdcb83f803fc83dd89e721

Modified Files
--------------
doc/src/sgml/catalogs.sgml | 23 ++-
doc/src/sgml/charset.sgml | 48 -----
doc/src/sgml/func.sgml | 8 +-
doc/src/sgml/ref/alter_collation.sgml | 63 +++++++
doc/src/sgml/ref/alter_index.sgml | 15 --
doc/src/sgml/ref/create_collation.sgml | 21 +++
doc/src/sgml/ref/pgupgrade.sgml | 15 --
doc/src/sgml/ref/reindex.sgml | 9 -
src/backend/catalog/dependency.c | 230 +++++------------------
src/backend/catalog/heap.c | 7 +-
src/backend/catalog/index.c | 198 ++-----------------
src/backend/catalog/pg_collation.c | 5 +
src/backend/catalog/pg_constraint.c | 2 +-
src/backend/catalog/pg_depend.c | 47 +----
src/backend/catalog/pg_type.c | 69 -------
src/backend/commands/collationcmds.c | 104 +++++++++-
src/backend/commands/statscmds.c | 2 +-
src/backend/commands/tablecmds.c | 31 ---
src/backend/nodes/copyfuncs.c | 14 +-
src/backend/nodes/equalfuncs.c | 11 ++
src/backend/optimizer/util/plancat.c | 9 -
src/backend/parser/gram.y | 26 ++-
src/backend/tcop/utility.c | 12 ++
src/backend/utils/adt/pg_locale.c | 89 ++++-----
src/backend/utils/adt/pg_upgrade_support.c | 1 -
src/backend/utils/cache/relcache.c | 2 -
src/bin/pg_dump/pg_backup.h | 1 -
src/bin/pg_dump/pg_dump.c | 216 +++------------------
src/bin/pg_dump/pg_dump.h | 2 -
src/bin/pg_upgrade/dump.c | 4 +-
src/bin/pg_upgrade/option.c | 7 -
src/bin/pg_upgrade/pg_upgrade.h | 1 -
src/bin/psql/tab-complete.c | 33 +---
src/include/catalog/catversion.h | 2 +-
src/include/catalog/dependency.h | 20 +-
src/include/catalog/index.h | 3 -
src/include/catalog/pg_collation.h | 8 +
src/include/catalog/pg_depend.h | 5 -
src/include/catalog/pg_type.h | 2 -
src/include/commands/collationcmds.h | 1 +
src/include/nodes/parsenodes.h | 13 +-
src/include/utils/pg_locale.h | 2 +-
src/include/utils/rel.h | 1 -
src/test/Makefile | 3 +-
src/test/locale/.gitignore | 1 -
src/test/locale/Makefile | 7 -
src/test/locale/t/001_index.pl | 67 -------
src/test/regress/expected/collate.icu.utf8.out | 195 +------------------
src/test/regress/expected/collate.linux.utf8.out | 3 +
src/test/regress/expected/create_index.out | 6 +-
src/test/regress/expected/misc_sanity.out | 4 +-
src/test/regress/sql/collate.icu.utf8.sql | 138 +-------------
src/test/regress/sql/collate.linux.utf8.sql | 5 +
src/test/regress/sql/create_index.sql | 4 +-
src/tools/pgindent/typedefs.list | 2 -
55 files changed, 463 insertions(+), 1354 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tomas Vondra 2021-05-07 12:47:09 pgsql: Fix typos in comments about extended statistics
Previous Message Alvaro Herrera 2021-05-06 21:32:11 pgsql: Remove redundant variable