| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Revert use singular for -1 (commits 9ee7d533da and 5da9868ed9 |
| Date: | 2021-05-01 14:42:56 |
| Message-ID: | E1lcqpc-0007bj-1C@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Revert use singular for -1 (commits 9ee7d533da and 5da9868ed9
Turns out you can specify negative values using plurals:
https://english.stackexchange.com/questions/9735/is-1-followed-by-a-singular-or-plural-noun
so the previous code was correct enough, and consistent with other usage
in our code. Also add comment in the two places where this could be
confused.
Reported-by: Noah Misch
Diagnosed-by: 20210425115726(dot)GA2353095(at)rfd(dot)leadboat(dot)com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/651d005e76bc0b9542615f609b4d0d946035dc58
Modified Files
--------------
contrib/dblink/expected/dblink.out | 6 +++---
src/backend/utils/adt/datetime.c | 5 +++--
src/interfaces/ecpg/pgtypeslib/interval.c | 5 +++--
src/interfaces/libpq/fe-print.c | 4 ++--
src/test/regress/expected/interval.out | 22 +++++++++++-----------
5 files changed, 22 insertions(+), 20 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Korotkov | 2021-05-03 01:19:44 | pgsql: Make websearch_to_tsquery() parse text in quotes as a single tok |
| Previous Message | Tom Lane | 2021-04-30 19:38:22 | pgsql: Doc: add an example of a self-referential foreign key to ddl.sgm |