pgsql: Fix pg_identify_object_as_address() with event triggers

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix pg_identify_object_as_address() with event triggers
Date: 2021-04-28 02:19:10
Message-ID: E1lbZnC-0001t4-5q@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix pg_identify_object_as_address() with event triggers

Attempting to use this function with event triggers failed, as, since
its introduction in a676201, this code has never associated an object
name with event triggers. This addresses the failure by adding the
event trigger name to the set defining its object address.

Note that regression tests are added within event_trigger and not
object_address to avoid issues with concurrent connections in parallel
schedules.

Author: Joel Jacobson
Discussion: https://postgr.es/m/3c905e77-a026-46ae-8835-c3f6cd1d24c8@www.fastmail.com
Backpatch-through: 9.6

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/f7aab36d61fd2fdbd949d5880247e8cae9ee4be0

Modified Files
--------------
src/backend/catalog/objectaddress.c | 11 +++++------
src/test/regress/expected/event_trigger.out | 17 +++++++++++++++++
src/test/regress/sql/event_trigger.sql | 11 +++++++++++
3 files changed, 33 insertions(+), 6 deletions(-)

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2021-04-28 02:44:08 Re: pgsql: Fix pg_identify_object_as_address() with event triggers
Previous Message Tom Lane 2021-04-28 00:01:38 Re: pgsql: Implement streaming mode in ReorderBuffer.