pgsql: Add macro PGWARNING, and make PGERROR available on all platforms

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Add macro PGWARNING, and make PGERROR available on all platforms
Date: 2021-04-11 17:23:01
Message-ID: E1lVdnZ-0007w5-Tj@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Add macro PGWARNING, and make PGERROR available on all platforms.

We'd previously noted the need for coping with Windows headers
that provide some other definition of macro "ERROR" than elog.h
does. It turns out that R also wants to define ERROR, and
WARNING too. PL/R has been working around this in a hacky way
that broke when we recently changed the numeric value of ERROR.
To let them have a more future-proof solution, provide an
alternate macro PGWARNING for WARNING, and make PGERROR visible
always, not only when #ifdef WIN32.

Discussion: https://postgr.es/m/CADK3HHK6iMChd1yoOqssxBn5Z14Zar8Ztr3G-N_fuG7F8YTP3w@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/d7cff12c4c035b7cf12bb8454824f48f13018730

Modified Files
--------------
src/include/utils/elog.h | 16 +++++++++-------
1 file changed, 9 insertions(+), 7 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2021-04-11 21:02:13 pgsql: Silence some Coverity warnings and improve code consistency.
Previous Message Tom Lane 2021-04-11 15:46:54 pgsql: Fix uninitialized variable from commit a4d75c86b.