pgsql: Fix potential rare failure in the kerberos TAP tests

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix potential rare failure in the kerberos TAP tests
Date: 2021-04-07 11:03:18
Message-ID: E1lU5xu-0006lj-Qi@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix potential rare failure in the kerberos TAP tests

Instead of writing a query to psql's stdin, which can cause a failure
where psql exits before writing, reporting a write failure with a broken
pipe, this changes the logic to use -c. This was not seen in the
buildfarm as no animals with a sensitive environment are running the
kerberos tests, but let's be safe.

HEAD is able to handle the situation as of 6d41dd0 for all the test
suites doing connection checks. f44b9b6 has fixed the same problem for
the LDAP tests.

Discussion: https://postgr.es/m/YGu7ceWAiSNQDgH5@paquier.xyz
Backpatch-through: 11

Branch
------
REL_11_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/c2c9d6756deaea91c60de8043a742c391a9e3f30

Modified Files
--------------
src/test/kerberos/t/001_auth.pl | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2021-04-07 11:13:43 Re: pgsql: Refactor all TAP test suites doing connection checks
Previous Message Heikki Linnakangas 2021-04-07 10:24:09 pgsql: Add sortsupport for gist_btree opclasses, for faster index build