pgsql: Fix use of cursor sensitivity terminology

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix use of cursor sensitivity terminology
Date: 2021-04-07 06:13:42
Message-ID: E1lU1Re-0004h6-GW@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix use of cursor sensitivity terminology

Documentation and comments in code and tests have been using the terms
sensitive/insensitive cursor incorrectly relative to the SQL standard.
(Cursor sensitivity is only relevant for changes made in the same
transaction as the cursor, not for concurrent changes in other
sessions.) Moreover, some of the behavior of PostgreSQL is incorrect
according to the SQL standard, confusing the issue further. (WHERE
CURRENT OF changes are not visible in insensitive cursors, but they
should be.)

This change corrects the terminology and removes the claim that
sensitive cursors are supported. It also adds a test case that checks
the insensitive behavior in a "correct" way, using a change command
not using WHERE CURRENT OF. Finally, it adds the ASENSITIVE cursor
option to select the default asensitive behavior, per SQL standard.

There are no changes to cursor behavior in this patch.

Discussion: https://www.postgresql.org/message-id/flat/96ee8b30-9889-9e1b-b053-90e10c050e85%40enterprisedb.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/dd13ad9d39a1ba41cf329b6fe408b49be57c7b88

Modified Files
--------------
doc/src/sgml/ecpg.sgml | 4 +--
doc/src/sgml/ref/declare.sgml | 49 +++++++++++++++++++++--------------
src/backend/catalog/sql_features.txt | 2 +-
src/backend/parser/analyze.c | 19 +++++++++-----
src/backend/parser/gram.y | 5 +++-
src/bin/psql/tab-complete.c | 2 +-
src/include/nodes/parsenodes.h | 3 ++-
src/include/parser/kwlist.h | 1 +
src/test/regress/expected/portals.out | 37 +++++++++++++++++++++++++-
src/test/regress/sql/portals.sql | 17 +++++++++++-
10 files changed, 105 insertions(+), 34 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Heikki Linnakangas 2021-04-07 10:24:09 pgsql: Add sortsupport for gist_btree opclasses, for faster index build
Previous Message Peter Eisentraut 2021-04-07 05:46:08 pgsql: Message improvement