pgsql: postgres_fdw: Allow partitions specified in LIMIT TO to be impor

From: Fujii Masao <fujii(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: postgres_fdw: Allow partitions specified in LIMIT TO to be impor
Date: 2021-04-06 17:32:44
Message-ID: E1lTpZE-0008MA-Nt@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

postgres_fdw: Allow partitions specified in LIMIT TO to be imported.

Commit f49bcd4ef3 disallowed postgres_fdw to import table partitions.
Because all data can be accessed through the partitioned table which
is the root of the partitioning hierarchy, importing only partitioned
table should allow access to all the data without creating extra objects.
This is a reasonable default when importing a whole schema. But there
may be the case where users want to explicitly import one of
a partitioned tables' partitions.

For that use case, this commit allows postgres_fdw to import tables or
foreign tables which are partitions of some other table only when they
are explicitly specified in LIMIT TO clause. It doesn't change
the behavior that any partitions not specified in LIMIT TO are
automatically excluded in IMPORT FOREIGN SCHEMA command.

Author: Matthias van de Meent
Reviewed-by: Bernd Helmle, Amit Langote, Michael Paquier, Fujii Masao
Discussion: https://postgr.es/m/CAEze2Whwg4i=mzApMe+PXxCEfgoZmHGqdqQFW7J4bmj_5p6t1A@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/a3740c48eb2f91663c7c06c948dfcfb6493d2588

Modified Files
--------------
contrib/postgres_fdw/expected/postgres_fdw.out | 36 ++++++++++++++------------
contrib/postgres_fdw/postgres_fdw.c | 11 +++++---
contrib/postgres_fdw/sql/postgres_fdw.sql | 6 +++--
doc/src/sgml/postgres-fdw.sgml | 10 ++++---
4 files changed, 37 insertions(+), 26 deletions(-)

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2021-04-06 19:57:42 pgsql: Postpone some stuff out of ExecInitModifyTable.
Previous Message Andres Freund 2021-04-06 16:27:29 pgsql: Increment xactCompletionCount during subtransaction abort.