pgsql: Allocate access strategy in parallel VACUUM workers.

From: Peter Geoghegan <pg(at)bowt(dot)ie>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Allocate access strategy in parallel VACUUM workers.
Date: 2021-04-06 00:19:52
Message-ID: E1lTZRg-0000tJ-5l@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Allocate access strategy in parallel VACUUM workers.

Commit 49f49def took entirely the wrong approach to fixing this issue.
Just allocate a local buffer access strategy in each individual worker
instead of trying to propagate state. This state was never propagated
by parallel VACUUM in the first place.

It looks like the only reason that this worked following commit 40d964ec
was that it involved static global variables, which are initialized to 0
per the C standard.

A more comprehensive fix may be necessary, even on HEAD. This fix
should at least get the buildfarm green once again.

Thanks once again to Thomas Munro for continued off-list assistance with
the issue.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/f6b8f19a084ce949522fcbc940dc116c034cfc47

Modified Files
--------------
src/backend/access/heap/vacuumlazy.c | 10 +++-------
1 file changed, 3 insertions(+), 7 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2021-04-06 00:27:26 Re: pgsql: Refactor all TAP test suites doing connection checks
Previous Message Tom Lane 2021-04-06 00:15:31 Re: pgsql: Refactor all TAP test suites doing connection checks