From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Improve style of some replication-related error messages. |
Date: | 2021-03-31 19:30:17 |
Message-ID: | E1lRgXh-0003J1-8W@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Improve style of some replication-related error messages.
Put the remote end's error message into the primary error string,
instead of relegating it to errdetail(). Although this could end up
being awkward if the remote sends us a really long error message,
it seems more in keeping with our message style guidelines, and more
helpful in situations where the errdetail could get dropped.
Peter Smith
Discussion: https://postgr.es/m/CAHut+Ps-Qv2yQceCwobQDP0aJOkfDzRFrOaR6+2Op2K=WHGeWg@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/6197db5340b8154adce1c6d07f6d3325547429c1
Modified Files
--------------
src/backend/commands/subscriptioncmds.c | 13 +++++--------
src/backend/replication/logical/tablesync.c | 8 ++++----
2 files changed, 9 insertions(+), 12 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Stephen Frost | 2021-03-31 20:24:42 | pgsql: Add a docs section for obsoleted and renamed functions and setti |
Previous Message | Alvaro Herrera | 2021-03-31 18:16:09 | pgsql: Fix some libpq_pipeline test problems |