pgsql: Stabilize stats_ext test with other collations

From: Tomas Vondra <tomas(dot)vondra(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Stabilize stats_ext test with other collations
Date: 2021-03-27 17:28:32
Message-ID: E1lQCjg-0000c6-Pf@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Stabilize stats_ext test with other collations

The tests used string concatenation to test statistics on expressions,
but that made the tests locale-dependent, e.g. because the ordering of
'11' and '1X' depends on the collation. This affected both the estimated
and actual row couts, breaking some of the tests.

Fixed by replacing the string concatenation with upper() function call,
so that the text values contain only digits.

Discussion: https://postgr.es/m/b650920b-2767-fbc3-c87a-cb8b5d693cbf%40enterprisedb.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/2a058e938c73bfb85bbc9fa93dea74788043ca6c

Modified Files
--------------
src/test/regress/expected/stats_ext.out | 204 ++++++++++++++++----------------
src/test/regress/sql/stats_ext.sql | 102 ++++++++--------
2 files changed, 153 insertions(+), 153 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Stephen Frost 2021-03-28 15:29:24 pgsql: doc: Define TLS as an acronym
Previous Message Peter Eisentraut 2021-03-27 09:20:04 pgsql: Improve consistency of SQL code capitalization