pgsql: Revert "Enable parallel SELECT for "INSERT INTO ... SELECT ...".

From: Amit Kapila <akapila(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Revert "Enable parallel SELECT for "INSERT INTO ... SELECT ...".
Date: 2021-03-24 06:42:15
Message-ID: E1lOxDb-0003fk-9G@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Revert "Enable parallel SELECT for "INSERT INTO ... SELECT ..."."

To allow inserts in parallel-mode this feature has to ensure that all the
constraints, triggers, etc. are parallel-safe for the partition hierarchy
which is costly and we need to find a better way to do that. Additionally,
we could have used existing cached information in some cases like indexes,
domains, etc. to determine the parallel-safety.

List of commits reverted, in reverse chronological order:

ed62d3737c Doc: Update description for parallel insert reloption.
c8f78b6161 Add a new GUC and a reloption to enable inserts in parallel-mode.
c5be48f092 Improve FK trigger parallel-safety check added by 05c8482f7f.
e2cda3c20a Fix use of relcache TriggerDesc field introduced by commit 05c8482f7f.
e4e87a32cc Fix valgrind issue in commit 05c8482f7f.
05c8482f7f Enable parallel SELECT for "INSERT INTO ... SELECT ...".

Discussion: https://postgr.es/m/E1lMiB9-0001c3-SY@gemulon.postgresql.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/26acb54a1368bf3706294400abca85b15c9233a6

Modified Files
--------------
doc/src/sgml/config.sgml | 23 -
doc/src/sgml/parallel.sgml | 3 -
doc/src/sgml/ref/alter_table.sgml | 3 +-
doc/src/sgml/ref/create_table.sgml | 31 +-
src/backend/access/common/reloptions.c | 25 +-
src/backend/access/transam/xact.c | 26 --
src/backend/executor/execMain.c | 3 -
src/backend/nodes/copyfuncs.c | 1 -
src/backend/nodes/outfuncs.c | 2 -
src/backend/nodes/readfuncs.c | 1 -
src/backend/optimizer/path/costsize.c | 2 -
src/backend/optimizer/plan/planner.c | 37 +-
src/backend/optimizer/util/clauses.c | 571 +------------------------
src/backend/utils/cache/plancache.c | 33 +-
src/backend/utils/misc/guc.c | 10 -
src/backend/utils/misc/postgresql.conf.sample | 1 -
src/bin/psql/tab-complete.c | 1 -
src/include/access/xact.h | 15 -
src/include/catalog/catversion.h | 2 +-
src/include/catalog/pg_proc.dat | 8 +-
src/include/nodes/pathnodes.h | 2 -
src/include/nodes/plannodes.h | 2 -
src/include/optimizer/clauses.h | 3 +-
src/include/optimizer/cost.h | 1 -
src/include/utils/rel.h | 25 --
src/test/regress/expected/insert_parallel.out | 586 --------------------------
src/test/regress/expected/sysviews.out | 3 +-
src/test/regress/parallel_schedule | 1 -
src/test/regress/serial_schedule | 1 -
src/test/regress/sql/insert_parallel.sql | 373 ----------------
src/tools/pgindent/typedefs.list | 1 -
31 files changed, 35 insertions(+), 1761 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2021-03-24 07:02:48 pgsql: Improve an error message
Previous Message tsunakawa.takay@fujitsu.com 2021-03-24 05:20:27 RE: pgsql: Add a new GUC and a reloption to enable inserts in parallel-mode