pgsql: Fix new TAP test for 2PC transactions and PITRs on Windows

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix new TAP test for 2PC transactions and PITRs on Windows
Date: 2021-03-22 00:52:08
Message-ID: E1lO8ng-00082G-DG@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix new TAP test for 2PC transactions and PITRs on Windows

The test added by 595b9cb forgot that on Windows it is necessary to set
up pg_hba.conf (see PostgresNode::set_replication_conf) with a specific
entry or base backups fail. Any node that requires to support
replication just needs to pass down allows_streaming at initialization.
This updates the test to do so. Simplify things a bit while on it.

Per buildfarm member fairywren. Any Windows hosts running this test
would have failed, and I have reproduced the problem as well.

Backpatch-through: 10

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/7bdc717a5438650c13b7dcde427828eb1743fd8c

Modified Files
--------------
src/test/recovery/t/023_pitr_prepared_xact.pl | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Noah Misch 2021-03-22 02:11:35 pgsql: Make a test endure log_error_verbosity=verbose.
Previous Message Michael Paquier 2021-03-22 00:01:17 pgsql: Simplify TAP tests of kerberos with expected log file contents