pgsql: Fix assorted silliness in ATExecSetCompression().

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix assorted silliness in ATExecSetCompression().
Date: 2021-03-21 22:43:26
Message-ID: E1lO6n8-00075z-UW@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix assorted silliness in ATExecSetCompression().

It's not okay to scribble directly on a syscache entry.
Nor to continue accessing said entry after releasing it.

Also get rid of not-used local variables.

Per valgrind testing.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/ac897c483485d3858ada23ca49650a0f2742a50f

Modified Files
--------------
src/backend/commands/tablecmds.c | 26 ++++++++++++--------------
1 file changed, 12 insertions(+), 14 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2021-03-21 23:31:45 pgsql: Fix timeline assignment in checkpoints with 2PC transactions
Previous Message Peter Geoghegan 2021-03-21 22:27:09 pgsql: Recycle nbtree pages deleted during same VACUUM.