pgsql: Bring configure support for LZ4 up to snuff.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Bring configure support for LZ4 up to snuff.
Date: 2021-03-21 21:20:24
Message-ID: E1lO5Um-0006T2-45@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Bring configure support for LZ4 up to snuff.

It's not okay to just shove the pkg_config results right into our
build flags, for a couple different reasons:

* This fails to maintain the separation between CPPFLAGS and CFLAGS,
as well as that between LDFLAGS and LIBS. (The CPPFLAGS angle is,
I believe, the reason for warning messages reported when building
with MacPorts' liblz4.)

* If pkg_config emits anything other than -I/-D/-L/-l switches,
it's highly unlikely that we want to absorb those. That'd be more
likely to break the build than do anything helpful. (Even the -D
case is questionable; but we're doing that for libxml2, so I kept it.)

Also, it's not okay to skip doing an AC_CHECK_LIB probe, as
evidenced by recent build failure on topminnow; that should
have been caught at configure time.

Model fixes for this on configure's libxml2 support.

It appears that somebody overlooked an autoheader run, too.

Discussion: https://postgr.es/m/20210119190720.GL8560@telsasoft.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/4d399a6fbeb720b34d33441330910b7d853f703d

Modified Files
--------------
configure | 64 ++++++++++++++++++++++++++++++++++++++++++++--
configure.ac | 18 +++++++++++--
src/include/pg_config.h.in | 11 +++++++-
src/tools/msvc/Solution.pm | 3 +++
4 files changed, 91 insertions(+), 5 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Geoghegan 2021-03-21 22:27:09 pgsql: Recycle nbtree pages deleted during same VACUUM.
Previous Message Tom Lane 2021-03-21 20:26:54 pgsql: Make compression.sql regression test independent of default.