pgsql: Use valid compression method in brin_form_tuple

From: Tomas Vondra <tomas(dot)vondra(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Use valid compression method in brin_form_tuple
Date: 2021-03-20 23:29:17
Message-ID: E1lNl1x-0007Gq-Er@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Use valid compression method in brin_form_tuple

When compressing the BRIN summary, we can't simply use the compression
method from the indexed attribute. The summary may use a different data
type, e.g. fixed-length attribute may have varlena summary, leading to
compression failures. For the built-in BRIN opclasses this happens to
work, because the summary uses the same data type as the attribute.

When the data types match, we can inherit use the compression method
specified for the attribute (it's copied into the index descriptor).
Otherwise we don't have much choice and have to use the default one.

Author: Tomas Vondra
Reviewed-by: Justin Pryzby <pryzby(at)telsasoft(dot)com>
Discussion: https://postgr.es/m/e0367f27-392c-321a-7411-a58e1a7e4817%40enterprisedb.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/882b2cdc08c4100e273f24742e2118be98708a07

Modified Files
--------------
src/backend/access/brin/brin_tuple.c | 16 ++++++++++++++--
1 file changed, 14 insertions(+), 2 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2021-03-21 07:12:36 pgsql: Move lwlock-release probe back where it belongs
Previous Message Tom Lane 2021-03-20 19:01:17 pgsql: Fix up pg_dump's handling of per-attribute compression options.