pgsql: In pg_amcheck tests, don't depend on perl's Q/q pack code.

From: Robert Haas <rhaas(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: In pg_amcheck tests, don't depend on perl's Q/q pack code.
Date: 2021-03-13 15:59:17
Message-ID: E1lL6fd-00053j-Lw@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

In pg_amcheck tests, don't depend on perl's Q/q pack code.

It does not work on all versions of perl across all platforms.

To avoid endian-ness issues, pick a new value for column a
that has the same upper 4 bytes as lower 4 bytes. Try to
make it something that isn't likely to occur anywhere nearby
in the page.

Discussion: http://postgr.es/m/29DA079B-0658-4E66-BDAA-0EFD7B64D9C6@enterprisedb.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/945d2cb7d0255e296a55f3e9febb5dce6eaccc3e

Modified Files
--------------
src/bin/pg_amcheck/t/004_verify_heapam.pl | 21 ++++++++++++---------
1 file changed, 12 insertions(+), 9 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2021-03-13 16:10:36 pgsql: Doc: add note about how to run the pg_amcheck regression tests.
Previous Message Tom Lane 2021-03-13 05:06:59 pgsql: pg_amcheck: Keep trying to fix the tests.