From: | Robert Haas <rhaas(at)postgresql(dot)org> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Fix portability issues in pg_amcheck's 004_verify_heapam.pl. |
Date: | 2021-03-12 22:37:11 |
Message-ID: | E1lKqP9-00078B-9P@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Fix portability issues in pg_amcheck's 004_verify_heapam.pl.
Test #12 overwrote a 1-byte varlena header to make it look like the
initial byte of a 4-byte varlena header, but the results were
endian-dependent. Also, the byte "abc" that followed the overwritten
byte would be interpreted differently depending on endian-ness.
Overwrite 4 bytes instead, in an endian-aware manner.
Test #13 accidentally managed to depend on TOAST_MAX_CHUNK_SIZE,
which varies slightly depending on MAXIMUM_ALIGNOF. That's not
the point anyway, so make the regexp insensitive to the expected
number of chunks.
Mark Dilger
Discussion: http://postgr.es/m/A80D68F6-E38F-482D-9522-E2FB6AAFE8A1@enterprisedb.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/661125612706b1d0d5ed9f12d18908b08512a7eb
Modified Files
--------------
src/bin/pg_amcheck/t/004_verify_heapam.pl | 72 ++++++++++++++++++-------------
1 file changed, 42 insertions(+), 30 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2021-03-13 00:04:30 | pgsql: Try to avoid apparent platform-dependency in IPC::Run |
Previous Message | Peter Geoghegan | 2021-03-12 21:14:23 | pgsql: Consolidate nbtree VACUUM metapage routines. |