pgsql: Improve new hash partition bound check error messages

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Improve new hash partition bound check error messages
Date: 2021-02-22 07:09:26
Message-ID: E1lE5LS-00071C-5o@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Improve new hash partition bound check error messages

For the error message "every hash partition modulus must be a factor
of the next larger modulus", add a detail message that shows the
particular numbers and existing partition involved. Also comment the
code more.

Reviewed-by: Amit Langote <amitlangote09(at)gmail(dot)com>
Reviewed-by: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
Discussion: https://www.postgresql.org/message-id/flat/bb9d60b4-aadb-607a-1a9d-fdc3434dddcd%40enterprisedb.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/efbfb642414b61db1567a7a902ace3f307d7564a

Modified Files
--------------
src/backend/partitioning/partbounds.c | 62 +++++++++++++++++++++---------
src/test/regress/expected/alter_table.out | 1 +
src/test/regress/expected/create_table.out | 2 +
3 files changed, 47 insertions(+), 18 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Fujii Masao 2021-02-22 09:26:12 pgsql: Initialize atomic variable waitStart in PGPROC, at postmaster st
Previous Message Michael Paquier 2021-02-22 05:22:03 pgsql: Use pgstat_progress_update_multi_param() where possible