From: | Alexander Korotkov <akorotkov(at)postgresql(dot)org> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: pg_attribute_no_sanitize_alignment() macro |
Date: | 2021-02-12 14:28:51 |
Message-ID: | E1lAZRD-0001Ad-FX@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
pg_attribute_no_sanitize_alignment() macro
Modern gcc and clang compilers offer alignment sanitizers, which help to detect
pointer misalignment. However, our codebase already contains x86-specific
crc32 computation code, which uses unalignment access. Thankfully, those
compilers also support the attribute, which disables alignment sanitizers at
the function level. This commit adds pg_attribute_no_sanitize_alignment(),
which wraps this attribute, and applies it to pg_comp_crc32c_sse42() function.
Discussion: https://postgr.es/m/CAPpHfdsne3%3DT%3DfMNU45PtxdhSL_J2PjLTeS8rwKnJzUR4YNd4w%40mail.gmail.com
Discussion: https://postgr.es/m/475514.1612745257%40sss.pgh.pa.us
Author: Alexander Korotkov, revised by Tom Lane
Reviewed-by: Tom Lane
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/993bdb9f935a751935a03c80d30857150ba2b645
Modified Files
--------------
src/include/c.h | 12 ++++++++++++
src/port/pg_crc32c_sse42.c | 1 +
2 files changed, 13 insertions(+)
From | Date | Subject | |
---|---|---|---|
Next Message | Alexander Korotkov | 2021-02-12 14:29:48 | Re: Detecting pointer misalignment (was Re: pgsql: Implementation of subscripting for jsonb) |
Previous Message | Andrey Borodin | 2021-02-12 05:22:34 | Re: pgsql: Add functions to 'pageinspect' to inspect GiST indexes. |