pgsql: Fix broken ruleutils support for function TRANSFORM clauses.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix broken ruleutils support for function TRANSFORM clauses.
Date: 2021-01-25 18:04:12
Message-ID: E1l46Dk-0005tZ-Vq@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix broken ruleutils support for function TRANSFORM clauses.

I chanced to notice that this dumped core due to a faulty Assert.
To add insult to injury, the output has been misformatted since v11.
Obviously we need some regression testing here.

Discussion: https://postgr.es/m/d1cc628c-3953-4209-957b-29427acc38c8@www.fastmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/07d46fceb4254b00e79f3d06419cbae13b0ecb5a

Modified Files
--------------
contrib/bool_plperl/expected/bool_plperl.out | 17 ++++++++++++++++-
contrib/bool_plperl/expected/bool_plperlu.out | 17 ++++++++++++++++-
contrib/bool_plperl/sql/bool_plperl.sql | 6 +++++-
contrib/bool_plperl/sql/bool_plperlu.sql | 6 +++++-
contrib/hstore_plpython/expected/hstore_plpython.out | 16 +++++++++++++---
contrib/hstore_plpython/sql/hstore_plpython.sql | 9 ++++++---
src/backend/utils/adt/ruleutils.c | 3 ++-
src/backend/utils/fmgr/funcapi.c | 5 +++--
8 files changed, 66 insertions(+), 13 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2021-01-25 18:04:13 pgsql: Fix broken ruleutils support for function TRANSFORM clauses.
Previous Message Robert Haas 2021-01-25 17:38:22 pgsql: Remove CheckpointLock.