pgsql: Introduce SHA1 implementations in the cryptohash infrastructure

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Introduce SHA1 implementations in the cryptohash infrastructure
Date: 2021-01-23 02:35:00
Message-ID: E1l38lQ-0007j7-GD@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Introduce SHA1 implementations in the cryptohash infrastructure

With this commit, SHA1 goes through the implementation provided by
OpenSSL via EVP when building the backend with it, and uses as fallback
implementation KAME which was located in pgcrypto and already shaped for
an integration with a set of init, update and final routines.
Structures and routines have been renamed to make things consistent with
the fallback implementations of MD5 and SHA2.

uuid-ossp has used for ages a shortcut with pgcrypto to fetch a copy of
SHA1 if needed. This was built depending on the build options within
./configure, so this cleans up some code and removes the build
dependency between pgcrypto and uuid-ossp.

Note that this will help with the refactoring of HMAC, as pgcrypto
offers the option to use MD5, SHA1 or SHA2, so only the second option
was missing to make that possible.

Author: Michael Paquier
Reviewed-by: Heikki Linnakangas
Discussion: https://postgr.es/m/X9HXKTgrvJvYO7Oh@paquier.xyz

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/a8ed6bb8f4cf259b95c1bff5da09a8f4c79dca46

Modified Files
--------------
configure | 19 +-
configure.ac | 24 +-
contrib/pgcrypto/Makefile | 2 +-
contrib/pgcrypto/internal.c | 34 +--
contrib/pgcrypto/sha1.c | 331 --------------------
contrib/uuid-ossp/.gitignore | 1 -
contrib/uuid-ossp/Makefile | 6 -
contrib/uuid-ossp/uuid-ossp.c | 27 +-
src/Makefile.global.in | 1 -
src/common/Makefile | 1 +
src/common/cryptohash.c | 11 +
src/common/cryptohash_openssl.c | 3 +
src/common/sha1.c | 369 +++++++++++++++++++++++
contrib/pgcrypto/sha1.h => src/common/sha1_int.h | 44 +--
src/include/common/cryptohash.h | 1 +
src/include/common/sha1.h | 19 ++
src/tools/msvc/Mkvcbuild.pm | 9 +-
src/tools/pgindent/typedefs.list | 1 +
18 files changed, 479 insertions(+), 424 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2021-01-23 20:08:45 pgsql: Update ecpg's connect-test1 for connection-failure message chang
Previous Message Bruce Momjian 2021-01-23 00:48:14 Re: pgsql: Re-allow DISTINCT in pl/pgsql expressions.