| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Switch "cl /?" to "cl /help" in MSVC scripts for platform detect |
| Date: | 2021-01-21 02:08:27 |
| Message-ID: | E1l2POd-0006sg-MG@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Switch "cl /?" to "cl /help" in MSVC scripts for platform detection
"cl /?" produces a different output if run on a real or a virtual drive
(this can be set with a simple subst command), causing an error in the
MSVC scripts if building on a virtual drive because the platform to use
cannot be detected.
"cl /help", on the contrary, produces a consistent output if used on a
real or virtual drive. Changing to "/help" allows the compilation to
work with a virtual drive as long as the top of the code repository is
part of the drive, without impacting the build on real drives.
Reported-by: Robert Grange
Author: Juan José Santamaría Flecha
Discussion: https://postgr.es/m/16825-c4f104bcebc67034@postgresql.org
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/733d670073efd2c3a9df07c225006668009ab793
Modified Files
--------------
src/tools/msvc/Solution.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2021-01-21 02:35:12 | pgsql: Fix initialization of FDW batching in ExecInitModifyTable |
| Previous Message | Tomas Vondra | 2021-01-20 22:58:50 | pgsql: Implement support for bulk inserts in postgres_fdw |