From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Further tweaking of PG_SYSROOT heuristics for macOS. |
Date: | 2021-01-20 17:08:31 |
Message-ID: | E1l2Gy7-0003qr-Sj@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Further tweaking of PG_SYSROOT heuristics for macOS.
It emerges that in some phases of the moon (perhaps to do with
directory entry order?), xcrun will report that the SDK path is
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk
which is normally a symlink to a version-numbered sibling directory.
Our heuristic to skip non-version-numbered pathnames was rejecting
that, which is the wrong thing to do. We'd still like to end up
with a version-numbered PG_SYSROOT value, but we can have that by
dereferencing the symlink.
Like the previous fix, back-patch to all supported versions.
Discussion: https://postgr.es/m/522433.1611089678@sss.pgh.pa.us
Branch
------
REL_10_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/a3345383d88b7410bee3d73852cfd5c0f5737973
Modified Files
--------------
src/template/darwin | 19 +++++++++++++------
1 file changed, 13 insertions(+), 6 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Tomas Vondra | 2021-01-20 21:58:05 | pgsql: psql \dX: list extended statistics objects |
Previous Message | Tom Lane | 2021-01-20 16:49:51 | pgsql: Disable vacuum page skipping in selected test cases. |