From: | Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Fix bug in detecting concurrent page splits in GiST insert |
Date: | 2021-01-20 09:59:35 |
Message-ID: | E1l2AH1-0001NQ-94@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Fix bug in detecting concurrent page splits in GiST insert
In commit 9eb5607e699, I got the condition on checking for split or
deleted page wrong: I used && instead of ||. The comment correctly said
"concurrent split _or_ deletion".
As a result, GiST insertion could miss a concurrent split, and insert to
wrong page. Duncan Sands demonstrated this with a test script that did a
lot of concurrent inserts.
Backpatch to v12, where this was introduced. REINDEX is required to fix
indexes that were affected by this bug.
Backpatch-through: 12
Reported-by: Duncan Sands
Discussion: https://www.postgresql.org/message-id/a9690483-6c6c-3c82-c8ba-dc1a40848f11%40deepbluecap.com
Branch
------
REL_13_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/b8403d140f4e7d753d21116c0fa79dc4ca5ca5cb
Modified Files
--------------
src/backend/access/gist/gist.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2021-01-20 16:49:51 | pgsql: Disable vacuum page skipping in selected test cases. |
Previous Message | Thomas Munro | 2021-01-20 09:49:25 | pgsql: Fix sample output of EXPLAIN ANALYZE. |