From: | Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Fix portability issues in the new gist pageinspect test. |
Date: | 2021-01-13 10:34:20 |
Message-ID: | E1kzdTo-00056a-AW@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Fix portability issues in the new gist pageinspect test.
1. The raw bytea representation of the point-type keys used in the test
depends on endianess. Remove the raw key_data column from the test.
2. The items stored on non-leftmost gist page depends on how many items
git on the other pages. This showed up as a failure on 32-bit i386
systems. To fix, only test the gist_page_items() function on the
leftmost leaf page.
Per Andrey Borodin and the buildfarm.
Discussion: https://www.postgresql.org/message-id/9FCEC1DC-86FB-4A57-88EF-DD13663B36AF%40yandex-team.ru
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/6ecaaf810b8b9e3132f00549e630400f38a7ca37
Modified Files
--------------
contrib/pageinspect/expected/gist.out | 52 ++++++++---------------------------
contrib/pageinspect/sql/gist.sql | 7 ++---
2 files changed, 15 insertions(+), 44 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Fujii Masao | 2021-01-13 14:01:12 | pgsql: Log long wait time on recovery conflict when it's resolved. |
Previous Message | Magnus Hagander | 2021-01-13 10:10:42 | pgsql: Remove incorrect markup |