pgsql: Further second thoughts about idle_session_timeout patch.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Further second thoughts about idle_session_timeout patch.
Date: 2021-01-07 16:45:46
Message-ID: E1kxYPy-0002OY-VP@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Further second thoughts about idle_session_timeout patch.

On reflection, the order of operations in PostgresMain() is wrong.
These timeouts ought to be shut down before, not after, we do the
post-command-read CHECK_FOR_INTERRUPTS, to guarantee that any
timeout error will be detected there rather than at some ill-defined
later point (possibly after having wasted a lot of work).

This is really an error in the original idle_in_transaction_timeout
patch, so back-patch to 9.6 where that was introduced.

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/5db4fdc22472919f97ce83d276fb34b47c794d1f

Modified Files
--------------
src/backend/tcop/postgres.c | 22 ++++++++++++----------
1 file changed, 12 insertions(+), 10 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2021-01-07 16:45:47 pgsql: Further second thoughts about idle_session_timeout patch.
Previous Message Tomas Vondra 2021-01-07 16:36:28 pgsql: Minor fixes in COPY progress docs