From: | Jeff Davis <jdavis(at)postgresql(dot)org> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Fix bug #16784 in Disk-based Hash Aggregation. |
Date: | 2020-12-27 01:53:25 |
Message-ID: | E1ktLFN-0008Vb-Ut@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Fix bug #16784 in Disk-based Hash Aggregation.
Before processing tuples, agg_refill_hash_table() was setting all
pergroup pointers to NULL to signal to advance_aggregates() that it
should not attempt to advance groups that had spilled.
The problem was that it also set the pergroups for sorted grouping
sets to NULL, which caused rescanning to fail.
Instead, change agg_refill_hash_table() to only set the pergroups for
hashed grouping sets to NULL; and when compiling the expression, pass
doSort=false.
Reported-by: Alexander Lakhin
Discussion: https://postgr.es/m/16784-7ff169bf2c3d1588%40postgresql.org
Backpatch-through: 13
Branch
------
REL_13_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/7b8692eaf113a56933c77cf4c3993716ab37e763
Modified Files
--------------
src/backend/executor/nodeAgg.c | 24 +++-
src/test/regress/expected/groupingsets.out | 207 +++++++++++++++++++++++++++++
src/test/regress/sql/groupingsets.sql | 21 +++
3 files changed, 245 insertions(+), 7 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2020-12-27 04:17:25 | Re: pgsql: Add pg_alterckey utility to change the cluster key |
Previous Message | Jeff Davis | 2020-12-27 01:53:13 | pgsql: Fix bug #16784 in Disk-based Hash Aggregation. |