pgsql: Clean up ancient test style

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Clean up ancient test style
Date: 2020-12-15 21:05:03
Message-ID: E1kpHVH-0001cF-GG@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Clean up ancient test style

Many older tests where written in a style like

SELECT '' AS two, i.* FROM INT2_TBL

where the first column indicated the number of expected result rows.
This has gotten increasingly out of date, as the test data fixtures
have expanded, so a lot of these were wrong and misleading. Moreover,
this style isn't really necessary, since the psql output already shows
the number of result rows.

To clean this up, remove all those extra columns.

Discussion: https://www.postgresql.org/message-id/flat/1a25312b-2686-380d-3c67-7a69094a999f%40enterprisedb.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/c06d6aa4c35177655e0fd4acaca888a73c3f9845

Modified Files
--------------
src/test/regress/expected/boolean.out | 256 +-
src/test/regress/expected/box.out | 224 +-
src/test/regress/expected/case.out | 120 +-
src/test/regress/expected/char.out | 112 +-
src/test/regress/expected/char_1.out | 112 +-
src/test/regress/expected/char_2.out | 112 +-
src/test/regress/expected/circle.out | 116 +-
.../regress/expected/float4-misrounded-input.out | 188 +-
src/test/regress/expected/float4.out | 188 +-
src/test/regress/expected/float8.out | 294 +-
src/test/regress/expected/geometry.out | 916 +++---
src/test/regress/expected/horology.out | 2654 ++++++++--------
src/test/regress/expected/inet.out | 304 +-
src/test/regress/expected/int2.out | 294 +-
src/test/regress/expected/int4.out | 292 +-
src/test/regress/expected/int8.out | 478 +--
src/test/regress/expected/interval.out | 244 +-
src/test/regress/expected/join.out | 3346 ++++++++++----------
src/test/regress/expected/name.out | 150 +-
src/test/regress/expected/numeric.out | 878 ++---
src/test/regress/expected/numerology.out | 66 +-
src/test/regress/expected/oid.out | 106 +-
src/test/regress/expected/path.out | 78 +-
src/test/regress/expected/point.out | 662 ++--
src/test/regress/expected/polygon.out | 20 +-
src/test/regress/expected/subselect.out | 162 +-
src/test/regress/expected/text.out | 10 +-
src/test/regress/expected/timestamp.out | 2312 +++++++-------
src/test/regress/expected/timestamptz.out | 2370 +++++++-------
src/test/regress/expected/varchar.out | 112 +-
src/test/regress/expected/varchar_1.out | 112 +-
src/test/regress/expected/varchar_2.out | 114 +-
src/test/regress/input/constraints.source | 30 +-
src/test/regress/output/constraints.source | 214 +-
src/test/regress/sql/boolean.sql | 36 +-
src/test/regress/sql/box.sql | 36 +-
src/test/regress/sql/case.sql | 12 +-
src/test/regress/sql/char.sql | 16 +-
src/test/regress/sql/circle.sql | 12 +-
src/test/regress/sql/float4.sql | 30 +-
src/test/regress/sql/float8.sql | 54 +-
src/test/regress/sql/geometry.sql | 46 +-
src/test/regress/sql/horology.sql | 32 +-
src/test/regress/sql/inet.sql | 18 +-
src/test/regress/sql/int2.sql | 52 +-
src/test/regress/sql/int4.sql | 58 +-
src/test/regress/sql/int8.sql | 54 +-
src/test/regress/sql/interval.sql | 18 +-
src/test/regress/sql/join.sql | 62 +-
src/test/regress/sql/name.sql | 22 +-
src/test/regress/sql/numeric.sql | 116 +-
src/test/regress/sql/numerology.sql | 6 +-
src/test/regress/sql/oid.sql | 14 +-
src/test/regress/sql/path.sql | 8 +-
src/test/regress/sql/point.sql | 32 +-
src/test/regress/sql/polygon.sql | 2 +-
src/test/regress/sql/subselect.sql | 20 +-
src/test/regress/sql/text.sql | 2 +-
src/test/regress/sql/timestamp.sql | 44 +-
src/test/regress/sql/timestamptz.sql | 50 +-
src/test/regress/sql/varchar.sql | 16 +-
61 files changed, 9257 insertions(+), 9257 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tomas Vondra 2020-12-15 22:36:37 pgsql: Error out when Gather Merge input is not sorted
Previous Message Tom Lane 2020-12-15 16:39:14 pgsql: Improve hash_create()'s API for some added robustness.