pgsql: jit: Correct parameter type for generated expression evaluation

From: Andres Freund <andres(at)anarazel(dot)de>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: jit: Correct parameter type for generated expression evaluation
Date: 2020-12-08 03:34:08
Message-ID: E1kmTlQ-0004Xy-QN@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

jit: Correct parameter type for generated expression evaluation functions.

clang only uses the 'i1' type for scalar booleans, not for pointers to
booleans (as the pointer might be pointing into a larger memory
allocation). Therefore a pointer-to-bool needs to the "storage" boolean.

There's no known case of wrong code generation due to this, but it seems quite
possible that it could cause problems (see e.g. 72559438f92).

Author: Andres Freund
Discussion: https://postgr.es/m/20201207212142.wz5tnbk2jsaqzogb@alap3.anarazel.de
Backpatch: 11-, where jit support was added

Branch
------
REL_12_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/27b57f806dc2da9d43657c0ef9569be9aac11e1c

Modified Files
--------------
src/backend/jit/llvm/llvmjit_expr.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2020-12-08 03:34:13 pgsql: jit: Correct parameter type for generated expression evaluation
Previous Message Andres Freund 2020-12-08 03:34:03 pgsql: backpatch "jit: Add support for LLVM 12."