pgsql: Add a couple of regression test cases related to array subscript

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Add a couple of regression test cases related to array subscript
Date: 2020-12-07 16:10:35
Message-ID: E1kmJ5v-0000Cr-1F@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Add a couple of regression test cases related to array subscripting.

Exercise some error cases that were never reached in the existing
regression tests. This is partly for code-coverage reasons, and
partly to memorialize the current behavior in advance of planned
changes for generic subscripting.

Also, I noticed that type_sanity's check to verify that all standard
types have array types was never extended when we added arrays for
all system catalog rowtypes (f7f70d5e2), nor when we added arrays
over domain types (c12d570fa). So do that. Also, since the query's
expected output isn't empty, it seems like a good idea to add an
ORDER BY to make sure the result stays stable.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/0a665bbc43c5a678331fb1b1f44274500eba6563

Modified Files
--------------
src/test/regress/expected/arrays.out | 13 +++++++++++++
src/test/regress/expected/rowtypes.out | 8 +++++++-
src/test/regress/expected/type_sanity.out | 12 ++++++------
src/test/regress/sql/arrays.sql | 5 +++++
src/test/regress/sql/rowtypes.sql | 4 ++++
src/test/regress/sql/type_sanity.sql | 12 ++++++------
6 files changed, 41 insertions(+), 13 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2020-12-07 18:49:11 Re: pgsql: Change the attribute name in pg_stat_replication_slots view.
Previous Message Heikki Linnakangas 2020-12-07 13:03:35 pgsql: Fix more race conditions in the newly-added pg_rewind test.