pgsql: Emit log when restore_command succeeds but archived file faills

From: Fujii Masao <fujii(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Emit log when restore_command succeeds but archived file faills
Date: 2020-11-20 06:43:30
Message-ID: E1kg08o-0001WR-4I@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Emit log when restore_command succeeds but archived file faills to be restored.

Previously, when restore_command claimed to succeed but failed to restore
the file with the right name, for example, due to mis-configuration of
restore_command, no log message was reported. Then the recovery failed
later with an error message not directly related to the issue.

This commit changes the recovery so that a log message is emitted in
this error case. This would enable us to investigate what happened in
this case more easily.

Author: Jeff Janes, Fujii Masao
Reviewed-by: Pavel Borisov, Kyotaro Horiguchi
Discussion: https://postgr.es/m/CAMkU=1xkFs3Omp4JR4wMYWdam_KLuj6LXnTYfU8u3T0h=PLLMQ@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/a4ef0329c27156dca81714854599e7d82becb17f

Modified Files
--------------
src/backend/access/transam/xlogarchive.c | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Thomas Munro 2020-11-20 08:58:40 pgsql: Add collation versions for FreeBSD.
Previous Message Tom Lane 2020-11-20 05:58:41 pgsql: On macOS, use -isysroot in link steps as well as compile steps.