pgsql: Add pg_nodiscard decorations to some functions

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Add pg_nodiscard decorations to some functions
Date: 2020-11-11 10:07:11
Message-ID: E1kcn1z-0001VU-PL@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Add pg_nodiscard decorations to some functions

Especially for the list API such as lappend() forgetting to assign the
return value is a common problem.

Reviewed-by: Michael Paquier <michael(at)paquier(dot)xyz>
Discussion: https://www.postgresql.org/message-id/flat/e3753562-99cd-b65f-5aca-687dfd1ec2fc(at)2ndquadrant(dot)com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/a378ba49a5cfec073d885f4943e1c7e4b83abd3b

Modified Files
--------------
src/include/nodes/pg_list.h | 62 ++++++++++++++++++++++-----------------------
src/include/utils/palloc.h | 4 +--
2 files changed, 33 insertions(+), 33 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Andrew Dunstan 2020-11-11 15:25:38 Re: pgsql: Declare assorted array functions using anycompatible not anyelem
Previous Message Peter Eisentraut 2020-11-11 07:05:37 pgsql: Fix cases of discarding result from list API functions