| From: | Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: pg_rewind: Fix thinko in parsing target WAL. |
| Date: | 2020-11-10 17:26:20 |
| Message-ID: | E1kcXPQ-00043L-Dd@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
pg_rewind: Fix thinko in parsing target WAL.
It's entirely possible to see WAL for a relation that doesn't exist in
the target anymore. That happens when the relation was dropped later.
The refactoring in commit eb00f1d4b broke that case, by sanity-checking
the file type in the target before checking the flag forwhether it
exists there at all.
I noticed this during manual testing. Modify the 001_basic.pl test so
that it covers this case.
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/72d172743e52f31bb874e3bbc07544b30bf0bb51
Modified Files
--------------
src/bin/pg_rewind/filemap.c | 21 ++++++++++++---------
src/bin/pg_rewind/t/001_basic.pl | 1 +
2 files changed, 13 insertions(+), 9 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2020-11-10 20:31:43 | Re: pgsql: Declare assorted array functions using anycompatible not anyelem |
| Previous Message | Andrew Dunstan | 2020-11-10 13:45:06 | Re: pgsql: Declare assorted array functions using anycompatible not anyelem |