pgsql: Avoid re-using output variables in new ecpg test case.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Avoid re-using output variables in new ecpg test case.
Date: 2020-11-07 21:25:49
Message-ID: E1kbViX-0005Z0-Dk@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Avoid re-using output variables in new ecpg test case.

The buildfarm thinks this leads to memory stomps, though annoyingly
I can't duplicate that here. The existing code in strings.pgc is
doing something that doesn't seem to be sanctioned at all really
by the documentation, but I'm disinclined to try to make that nicer
right now. Let's just declare some more output variables in hopes
of working around it.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/eed4356fad84b0fd6e3caa49c7006f401159ac9a

Modified Files
--------------
src/interfaces/ecpg/test/expected/preproc-strings.c | 10 ++++++----
src/interfaces/ecpg/test/expected/preproc-strings.stderr | 4 ++++
src/interfaces/ecpg/test/preproc/strings.h | 4 +++-
src/interfaces/ecpg/test/preproc/strings.pgc | 4 ++--
4 files changed, 15 insertions(+), 7 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2020-11-07 22:04:38 pgsql: Fix redundant error messages in client tools
Previous Message Tom Lane 2020-11-07 20:27:45 pgsql: Doc: small release note updates.