From: | Tomas Vondra <tomas(dot)vondra(at)postgresql(dot)org> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Fix get_useful_pathkeys_for_relation for volatile expressions |
Date: | 2020-11-03 21:33:01 |
Message-ID: | E1ka3vJ-0006DC-MO@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Fix get_useful_pathkeys_for_relation for volatile expressions
When considering Incremental Sort below a Gather Merge, we need to be
a bit more careful when matching pathkeys to EC members. It's not enough
to find a member whose Vars are all in the current relation's target;
volatile expressions in particular need to be contained in the target,
otherwise it's too early to use the pathkey.
Reported-by: Jaime Casanova
Author: James Coleman
Reviewed-by: Tomas Vondra
Backpatch-through: 13, where the incremental sort code was added
Discussion: https://postgr.es/m/CAJGNTeNaxpXgBVcRhJX%2B2vSbq%2BF2kJqGBcvompmpvXb7pq%2BoFA%40mail.gmail.com
Branch
------
REL_13_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/2d26c4ac703447a002a02124c1edd01e70a5d1ee
Modified Files
--------------
src/backend/optimizer/path/allpaths.c | 13 ++--
src/backend/optimizer/path/equivclass.c | 70 ++++++++++++++++++
src/include/optimizer/paths.h | 1 +
src/test/regress/expected/incremental_sort.out | 98 ++++++++++++++++++++++++++
src/test/regress/sql/incremental_sort.sql | 31 ++++++++
5 files changed, 207 insertions(+), 6 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2020-11-04 01:24:34 | pgsql: Revert pg_relation_check_pages() |
Previous Message | Tomas Vondra | 2020-11-03 21:32:49 | pgsql: Fix get_useful_pathkeys_for_relation for volatile expressions |